Plugins [Official] mcMMO - Original Author Returns!

• Added Tridents / Crossbows to salvage.vanilla.yml config (see notes)
• Fixed an issue where Folia could have all of its threads lock up effectively killing the server
• Fixed concurrency issue with Folia regarding locale strings
• Fixed concurrency issue with Folia regarding COTW summons
• Updated 'Salvage.SubSkill.ScrapCollector.Stat' to no longer mention luck being involved
• The amount of materials from salvage are no longer luck-based, you will get a deterministic amount based on damage to the item.
• Fixed Ricocheted arrows losing some data after a ricochet
• Changed color of locale strings for 'Repair.Listener.Anvil' to be easier to read
• Changed color of locale strings for 'Salvage.Listener.Anvil' to be easier to read

NOTES:

• Tridents and Crossbows are now in the salvage.vanilla.yml config, you will need to either delete this config file to regenerate it or add the entries manually.
• You can check the default config file after running this mcMMO update at least once in the defaults folder at plugins\mcMMO\defaults to see what you would need to add if you want to take the manual approach

• Compatibility with Minecraft 1.21.3
• (API) add causingPlayer to McMMOReplaceVanillaTreasureEvent and update Fish Event to use it (thanks bobcat4848 and Jacob Cuomo)

Notes:
Tested this version of mcMMO against 1.21.3, 1.21.1, and 1.19.4, which should be full coverage for all the changes, but it is possible you will run into things I didn't catch.
Please report any errors or bugs on our GitHub issues page if you find them.

• (Codebase) Reworked Roll implementation (See notes)
• (Codebase) Added unit test coverage for Roll
• Fixed Alchemy error spam in mcMMO potion matching logic (see notes)
• Fixed Alchemy NPE when brewing finishes
• Fixed a bug where Roll was modifying damage unnecessarily
• Fixed blast mining trying to drop non-items (thanks IAISI)

NOTES:
I'll need to rework Alchemy config logic a bit further to address some issues I've found, for now mcMMO will ignore harmless matching errors in the potion matching logic.
The code for Roll was a bit of a mess, I've rewritten a good chunk of it and added some unit test coverage.
I will likely put out another update for Acrobatics in general, as the code fo

• Fixed issue where Roll wasn't reducing as much damage as it should have been (thanks Ineusia)
• Updated locale_es (thanks Devilcasters)
• Updated locale_lt_LT (thanks tautuxs)

• Optimized Alchemy code (thanks MrPowerGamerBR)
• Fixed an exception that could occur when shooting entities through worlds (thanks Wariorrrr)
• Fixes to en_US locale (thanks BlockMasters617)
• Maces, Crossbows, and Tridents skill commands don't warn you that they are work in progress anymore.
• Fixed IllegalArgumentException when Rupture would trigger on an entity with illegal state

NOTES:
Maces, Crossbows, and Tridents are still in development, the change to remove the message from the skill command was to reduce the visual noise.

• Fixed a probability bug where certain skills would max out in chance to succeed well before they were supposed to (such as Dodge)
• Blast Mining will no longer drop mob spawners (see notes)
• (Codebase) Added more unit tests for Probability and RNG
• The Herbalism XP gained when breaking certain plants that can grow unnaturally tall vertically (bamboo, kelp) is now capped to the most it could give when naturally grown, this can be disabled in experience.yml
• Added...

• Fixed a bug with default Mace permissions (thanks SrBedrock)
• Fixed Blast Mining being almost completely broken
• Reworked Blast Mining to drop non-mining related blocks too
• Reworked Blast Mining to use your pickaxe when determining drops (will apply Silk Touch)
• Fixed shift-clicking ingredients into the brewing stand not working on older versions of Minecraft
• Added a setting in advanced.yml to ignore attack cooldowns (see notes)
• Updated zh_CN locale (thanks libook)...

• (SQL) Fixed a bug where skill cooldowns were being loaded for players incorrectly

• Added Maces skill
• Added Mace to repair.vanilla.yml (see notes)
• Fixed a bug where spamming attacks would still apply full bonus dmg and full chance to proc abilities (see notes)
• Fixed some misc missing permissions for crossbows/tridents

NOTES:
You shouldn't need to update repair.vanilla.yml, it should update automatically
Maces is a new skill that is in early development, feedback is appreciated.
Some ideas I had for the Maces are on hold as they are lacking proper API from Spigot.
This is mostly pertaining to smash attacks, I had some ideas for enhancing them but without the proper API I will hold off for now.
While working on Maces, I noticed a bug where spamming attacks would still apply full bonus damage and full chance to proc abilities, this has been fixed.
When you swing your weapon in Minecraft, you gain an "Attack Strength" value, which is relative to your cooldown, mcMMO was supposed to be making use of this value, but at some point in the past this was broken.
I have fixed this and now mcMMO will use the attack strength value to determine the bonus damage and chance to proc abilities.
For servers modifying Minecraft combat to not have this "cooldown", mcMMO should behave as you would expect, with full damage and full chance to proc abilities even when spamming attacks.

• Fixed a bug where Luck Of The Sea was being applied for Super Breaker (and other abilities)